server: check NotAfter when loading journal #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
sorindumitru
force-pushed
the
journal-not-after
branch
from
c52fe71 to
b36987a
Compare
amartinezfayo
previously approved these changes
Feb 6, 2025
|
Looks like the DCO check failed, maybe because the commit was done from the GitHub UI? |
sorindumitru
force-pushed
the
journal-not-after
branch
from
07ec2c0 to
df21edf
Compare
Otherwise we can end up with expired CAs which leads to issues Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
force-pushed
the
journal-not-after
branch
from
df21edf to
d623468
Compare
amartinezfayo
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we can end up with expired CAs which leads to issues later on, such as in #5796
Pull Request check list
Affected functionality
spire-server CA journal loading
Description of change
Verify that the keys in the journal are not expired before loading them.
Which issue this PR fixes
fixes #5796