Use a temporary file for the fakedatastore #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
sorindumitru
force-pushed
the
fakedatastore
branch
2 times, most recently
from
485d18d to
d6f3a71
Compare
amartinezfayo
approved these changes
Jan 28, 2025
sorindumitru
force-pushed
the
fakedatastore
branch
3 times, most recently
from
3bbe7ba to
460bf3c
Compare
With a in memory sqlite datastore the database gets cleaned up when all connections to it get closed. If that happens, the next connection to be opened will see an empty database and usually error out. I've noticed this in tests ocassionally and this seems to make running the db using not fail. Signed-off-by: Sorin Dumitru <[email protected]>
sorindumitru
force-pushed
the
fakedatastore
branch
from
460bf3c to
f3971e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a in memory sqlite datastore the database gets cleaned up when all connections to it get closed. If that happens, the next connection to be opened will see an empty database and usually error out.
I've noticed this in tests ocassionally and this seems to make running the db using not fail. For example this seems to fix #5789 and #5774 . I think it's worth testing it out for a while to see if those issues resurface.