Add sprig functions #5593
Add sprig functions #5593
Conversation
kfox1111
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
| "deepCopy", | ||
| "mustDeepCopy", | ||
| "typeOf", | ||
| "typeIs", | ||
| "typeIsLike", | ||
| "kindOf", | ||
| "kindIs", | ||
| "deepEqual", |
There was a problem hiding this comment.
I'd probably leave out the reflection funcs for now?
| sprigMap := sprig.TxtFuncMap() | ||
| ourMap := make(template.FuncMap) | ||
| for _, f := range funcList { | ||
| ourMap[f] = sprigMap[f] |
There was a problem hiding this comment.
We should fail if the expected function does not exist in sprigMap (e.g. we had a typo or a function was removed)
| sprigMap := sprig.TxtFuncMap() | ||
| ourMap := make(template.FuncMap) | ||
| for _, f := range funcList { |
There was a problem hiding this comment.
I'd probably construct ourMap once at package initialization time?
| ) | ||
|
|
||
| var funcList = [...]string{ |
There was a problem hiding this comment.
| var funcList = [...]string{ | |
| var funcList = []string{ |
| "randAscii", | ||
| "randNumeric", | ||
| "swapcase", | ||
| "shuffle", |
There was a problem hiding this comment.
🤔 I'd probably leave this one out?
| "toJson", | ||
| "toPrettyJson", | ||
| "toRawJson", |
There was a problem hiding this comment.
Can't imagine wanting to convert something to JSON inside of a path template...
| "mustToJson", | ||
| "mustToPrettyJson", | ||
| "mustToRawJson", |
There was a problem hiding this comment.
Can't imagine wanting to convert something to JSON inside of a path template...
|
Hmm, looking at the failing windows integration test, I think we're falling victim to package init order.... |
Fixes: spiffe#5575 Signed-off-by: Kevin Fox <[email protected]>
|
The string its failing on (sha512sum) isn't in the codebase anywhere anymore.... It was in an earlier version of the pr. Could the vm be persisting a bad pr somehow? |
Fixes: #5575