-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated -ttl flag from spire server cli #5483
Conversation
This commit removes the deprecated `-ttl` flag from `spire entry create` and `spire entry update`. Docs are also updated. See discussion in spiffe#5254 Signed-off-by: Marcel Levy <marcel@spirl.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @heymarcel !
can you update ITs that are using -ttl and replace that with x509SVIDTTL or jwtSVIDTTL depending the case? |
@MarcosDY Sorry about missing the integration tests. I have them working now, but I notice the Windows unit tests are still failing. Is that expected, or am I missing something? https://github.com/heymarcel/spire/actions/runs/10815947896/job/30006064864 |
Thanks for taking care of this! |
Thanks! I've got that running now as well. |
Looks good but, one last thing, |
Signed-off-by: Marcel Levy <marcel@spirl.com>
Signed-off-by: Marcel Levy <marcel@spirl.com>
This commit removes the deprecated
-ttl
flag fromspire entry create
andspire entry update
.See discussion in issue #5254.
Pull Request check list
Affected functionality
This commit removes the deprecated
-ttl
flag fromspire entry create
andspire entry update
.Description of change
As per the issue referenced above:
Which issue this PR fixes
fixes#5254