Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tonistiigi/xx from 1.3.0 to 1.5.0 in Dockerfile #5448

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Bump tonistiigi/xx from 1.3.0 to 1.5.0 in Dockerfile #5448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e25d1ec
Bump tonistiigi/xx from 1.3.0 to 1.5.0 in Dockerfile
marcofranssen Sep 2, 2024
4827936
Merge branch 'main' into bump-xx-docker
MarcosDY Sep 8, 2024
fd4e4d7
Merge branch 'main' into bump-xx-docker
MarcosDY Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ COPY . .
# when bumping to a new version analyze the new version for security issues
# then use crane to lookup the digest of that version so we are immutable
# crane digest tonistiigi/xx:1.3.0
FROM --platform=$BUILDPLATFORM tonistiigi/xx@sha256:904fe94f236d36d65aeb5a2462f88f2c537b8360475f6342e7599194f291fb7e AS xx
FROM --platform=$BUILDPLATFORM tonistiigi/xx:1.5.0@sha256:0c6a569797744e45955f39d4f7538ac344bfb7ebf0a54006a0a4297b153ccf0f AS xx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you continue using only the sha256 digest?

Suggested change
FROM --platform=$BUILDPLATFORM tonistiigi/xx:1.5.0@sha256:0c6a569797744e45955f39d4f7538ac344bfb7ebf0a54006a0a4297b153ccf0f AS xx
FROM --platform=$BUILDPLATFORM tonistiigi/xx@sha256:0c6a569797744e45955f39d4f7538ac344bfb7ebf0a54006a0a4297b153ccf0f AS xx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this is is more obvious which image version is used. Therefore included the tag. Sha will still be leading when pulling the image.


FROM --platform=${BUILDPLATFORM} base as builder
ARG TAG
Expand Down
Loading