Propogate SQLTransactionTimeout #5345
Conversation
Signed-off-by: Faisal Memon <[email protected]>
faisal-memon
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
| @@ -397,6 +397,7 @@ func (s *Server) newEndpointsServer(ctx context.Context, catalog catalog.Catalog | |||
| CacheReloadInterval: s.config.CacheReloadInterval, | |||
| EventsBasedCache: s.config.EventsBasedCache, | |||
| PruneEventsOlderThan: s.config.PruneEventsOlderThan, | |||
| SQLTransactionTimeout: s.config.SQLTransactionTimeout, | |||
There was a problem hiding this comment.
it'd be nice to unit test, considering lack thereof caused the gap
There was a problem hiding this comment.
Hey @amoore877 That was my first thought too. Unfortunately I dont know where to work in a unit test here as the fields just end up as unexported fields in the endpoints object.
There was a problem hiding this comment.
ah, and there's no way to easily test with a running module and infer behavior from config I guess. sad times.
the most I've done sometimes in such cases at least verify those unexported fields (which would be accessible in a same-package test) are set as expected. it's one of those kinds of tests that seems silly at first, but catches simple mistakes.
better though would be that behavioral check, but that seems hard compared to the effort of the fix :)
Pull Request check list
Affected functionality
Events based cache
Description of change
Fixes bug where SQLTransactionTimeout is not propagated
Which issue this PR fixes
fixes #5343