add SVID check to agent health check #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manbeardo
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: James Ribe <[email protected]>
Manbeardo
force-pushed
the
agent-svid-health-check
branch
from
cf9ebbb to
12cc772
Compare
|
replaced |
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Sep 3, 2024
This reverts commit 033d8d6. Signed-off-by: Agustín Martínez Fayó <[email protected]>
Closed
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Sep 3, 2024
This reverts commit 033d8d6. Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
added a commit
that referenced
this pull request
Sep 3, 2024
This reverts commit 033d8d6. Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Sep 4, 2024
…ranch This reverts commit 033d8d6. Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
added a commit
that referenced
this pull request
Sep 4, 2024
…5461) This reverts commit 033d8d6. Signed-off-by: Agustín Martínez Fayó <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
spire-agent health check
Description of change
This diff makes the agent health check report unhealthy until the agent has secured an SVID.
I could use some help figuring out how to test this since I was able to find tests covering the health check infrastructure, but none covering the actual health check conditions.
I could also use a pointer at any documentation that would need updating.
Which issue this PR fixes
#5297