Build the SPIRE Agent Docker image to run as root by default #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartinezfayo
requested review from
evan2645,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: Agustín Martínez Fayó <[email protected]>
amartinezfayo
force-pushed
the
agent-docker-image-root
branch
from
bbf4a60 to
4bed549
Compare
azdagron
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the SPIRE Agent Docker image to run as root by default as we have been doing in previous releases.
Running it as a non-root user would be pretty disruptive for users running SPIRE in Kubernetes environments, where the use of a hostPath volume is needed for the SPIRE Agent container to share the agent socket.