-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce EJBCA UpstreamAuthority plugin for SPIRE Server #5201
Conversation
Signed-off-by: Hayden Roszell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @m8rmclaren for this contribution!
While we are waiting for the integration tests to complete the review, I just wanted to provide a couple of comments.
refactor EJBCA config to only support certs from file Signed-off-by: Hayden Roszell <[email protected]>
Signed-off-by: Hayden Roszell <[email protected]>
…BCA docs Signed-off-by: Hayden Roszell <[email protected]>
Hi @amartinezfayo - I made the recommended changes to |
Hi @m8rmclaren, just checking in here. Do you need any help or have questions about the latests comments? |
Signed-off-by: Hayden Roszell <[email protected]>
Signed-off-by: Hayden Roszell <[email protected]>
…r to use non-OAuth server config Signed-off-by: Hayden Roszell <[email protected]>
Signed-off-by: Hayden Roszell <[email protected]>
Hi @amartinezfayo! I believe I've resolved the suggestions from your review, with the most important change being the removal of OAuth as an auth method. I also resolved the issue in the EJBCA integration test, and verified that the GitHub Actions run in my fork. |
Pull Request check list
Affected functionality
This PR introduces EJBCA as a Server UpstreamAuthority plugin. This plugin uses a connected EJBCA to issue intermediate certificates for the SPIRE server.
Description of change
golang.org/x/oauth2
tov0.21.0
required when importing the EJBCA Go Client SDK.Which issue this PR fixes