Fix error tracking for entry cache telemetry#2091
Merged
azdagron merged 1 commit intospiffe:masterfrom Jan 29, 2021
Merged
Conversation
The lack of a named error variable (and an accidental capture) was preventing the deferred call counter done method from picking up the error returned from building the cache. This change fixes the bug by naming the error variable in the closure. Signed-off-by: Andrew Harding <aharding@vmware.com>
azdagron
requested review from
APTy,
amartinezfayo,
evan2645 and
rturner3
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of a named error variable (and an accidental capture) was preventing the deferred call counter done method from picking up the error returned from building the cache.
This change fixes the bug by naming the error variable in the closure.