Log errors in failed user/group name lookup in unix workload attestor#2048
Merged
azdagron merged 3 commits intospiffe:masterfrom Jan 13, 2021
Merged
Log errors in failed user/group name lookup in unix workload attestor#2048azdagron merged 3 commits intospiffe:masterfrom
azdagron merged 3 commits intospiffe:masterfrom
Conversation
Signed-off-by: Ryan Turner <turner@uber.com>
rturner3
requested review from
APTy,
amartinezfayo,
azdagron and
evan2645
as code owners
azdagron
reviewed
Jan 12, 2021
| func (p *Plugin) getUserName(uid string) (string, bool) { | ||
| u, err := p.hooks.lookupUserByID(uid) | ||
| if err != nil { | ||
| p.log.Warn("failed to lookup user name by uid", "uid", uid, "error", err) |
Member
There was a problem hiding this comment.
nit: log messages should start with uppercase
| func (p *Plugin) getGroupName(gid string) (string, bool) { | ||
| g, err := p.hooks.lookupGroupByID(gid) | ||
| if err != nil { | ||
| p.log.Warn("failed to lookup group name by gid", "gid", gid, "error", err) |
Member
There was a problem hiding this comment.
nit: log messages should start with uppercase
Collaborator
Author
There was a problem hiding this comment.
Thanks for this @rturner3. Other than the nitpicks on the log casing, I was wondering how you felt about throwing together a few test cases to test the logging? Should hopefully be a quick addition to the PR.
Sure, added some test coverage.
added 2 commits
January 12, 2021 16:19
Signed-off-by: Ryan Turner <turner@uber.com>
Signed-off-by: Ryan Turner <turner@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
unixWorkload Attestor pluginDescription of change
Adding logging in cases where looking up a Unix user name by
uidor a Unix group name bygidfails. Currently, theunixattestor swallows these errors without logging or returning them. This makes it difficult to understand workload attestation failures that might be caused by one of theunix:userorunix:groupselectors not being properly identified.Which issue this PR fixes
fixes #2040