Keymanager plugin calls timeout#2044
Merged
evan2645 merged 2 commits intospiffe:masterfrom Jan 19, 2021
Merged
Conversation
kunzimariano
requested review from
APTy,
amartinezfayo,
azdagron,
evan2645 and
rturner3
as code owners
Signed-off-by: Mariano Kunzi <kunzi.mariano@gmail.com>
kunzimariano
force-pushed
the
add_timeouts_keymanager_plugin
branch
from
bb1c4d7 to
1961cd7
Compare
evan2645
approved these changes
Jan 19, 2021
Member
evan2645
left a comment
evan2645
left a comment
There was a problem hiding this comment.
Thank you for this @kunzimariano!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for a new keymanager plugin that depends on an external resource, and based on what was presented here. This PR adds timeouts to keymanager plugin calls, as an upper bound of 30 seconds.
--
Fixes #1963