Report uptime as metrics for spire server and agent with config#2032
Report uptime as metrics for spire server and agent with config#2032amartinezfayo merged 8 commits intospiffe:masterfrom
Conversation
|
Thank you @hixichen for this contribution. |
Hi,Agustín: |
Signed-off-by: CHEN XI <cxi@uber.com>
Signed-off-by: CHEN XI <cxi@uber.com>
Signed-off-by: CHEN XI <cxi@uber.com>
Signed-off-by: CHEN XI <cxi@uber.com>
e42a8bf to
2e14964
Compare
|
@amartinezfayo let me know if you have other comments. thanks. |
amartinezfayo
left a comment
There was a problem hiding this comment.
Thank you @hixichen for providing the details. I think that it makes sense to add this metric to cover that case.
My main concern is around the new agent/server config settings added. Please see my comments about that.
Signed-off-by: CHEN XI <cxi@uber.com>
amartinezfayo
left a comment
There was a problem hiding this comment.
I left a few nitpicks. We should be ready to go after that.
Thank you @hixichen for your patience!
Signed-off-by: CHEN XI <cxi@uber.com>
|
Yay! |
…fe#2032) * Report update time as metrics for spire server and agent Signed-off-by: CHEN XI <cxi@uber.com>
Pull Request check list
Affected functionality
Description of change
Add a uptime metrics for spire-agent and spire-server.
The goal here is to t indicate both Spire agent and Spire server are healthy.
And, uptime metric will help to determine if the process is periodically crashing.
This is different compared to the existing uptime in the debug API.
Test locally:
Which issue this PR fixes
fixes #1231