Skip to content

Set TLS 1.2 minimum for all endpoints #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azdagron merged 2 commits into from
Dec 18, 2020
Merged

Set TLS 1.2 minimum for all endpoints #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
200028b
Set TLS 1.2 minimum for all endpoints
Dec 18, 2020
46d49fb
Merge branch 'master' into set-tls12-minimum-for-all-endpoints
Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/server/endpoints/bundle/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,13 @@ func (s *Server) ListenAndServe(ctx context.Context) error {
return errs.Wrap(err)
}

// Set up the TLS config, setting TLS 1.2 as the minimum.
tlsConfig := s.c.ServerAuth.GetTLSConfig()
tlsConfig.MinVersion = tls.VersionTLS12

server := &http.Server{
Handler: http.HandlerFunc(s.serveHTTP),
TLSConfig: s.c.ServerAuth.GetTLSConfig(),
TLSConfig: tlsConfig,
}

errCh := make(chan error, 1)
Expand Down
1 change: 1 addition & 0 deletions support/k8s/k8s-workload-registrar/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ func NewServer(config ServerConfig) (*Server, error) {

tlsConfig := &tls.Config{
Certificates: []tls.Certificate{cert},
MinVersion: tls.VersionTLS12,
}
if !config.InsecureSkipClientVerification {
tlsConfig.ClientAuth = tls.RequireAndVerifyClientCert
Expand Down