Update Makefile to accept arguments in the integration target#2013
Merged
azdagron merged 5 commits intospiffe:masterfrom Dec 17, 2020
Merged
Update Makefile to accept arguments in the integration target#2013azdagron merged 5 commits intospiffe:masterfrom
azdagron merged 5 commits intospiffe:masterfrom
Conversation
Signed-off-by: Ryuma Yoshida <ryuma.y1117@gmail.com>
ryysud
requested review from
APTy,
amartinezfayo,
azdagron,
evan2645 and
mcpherrinm
as code owners
3 tasks
Member
amartinezfayo
left a comment
amartinezfayo
left a comment
There was a problem hiding this comment.
Thank you @ryysud for this improvement.
I think that it would be good to update the help target to document the existence of this.
Signed-off-by: Ryuma Yoshida <ryuma.y1117@gmail.com>
Contributor
Author
|
Thank you for your review, @amartinezfayo. I fixed it with b773231. $ make help
...
Test:
test - run unit tests
race-test - run unit tests with race detection
integration - run integration tests (requires Docker images)
support 'SUITES' variable for executing specific tests
e.g. SUITES='suites/join-token suites/k8s' make integration
... |
Signed-off-by: Ryuma Yoshida <ryuma.y1117@gmail.com>
Contributor
Author
|
Thank you your review, @azdagron! I fixed the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryuma Yoshida ryuma.y1117@gmail.com
Pull Request check list
Affected functionality
make integrationDescription of change
I updated Makefile to accept arguments in the integration target.
With this change, we can run a specific integration test via
make integrationas below:SUITES=suites/join-token make integration SUITES='suites/k8s suites/join-token' make integrationWhich issue this PR fixes
Nothing.