Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

ingress-nginx production tests and spiffe-oidc-discovery-provider example #136

Merged
merged 40 commits into from
Aug 29, 2023
Merged

ingress-nginx production tests and spiffe-oidc-discovery-provider example #136

merged 40 commits into from
Aug 29, 2023

Conversation

kfox1111
Copy link
Contributor

@kfox1111 kfox1111 commented Mar 17, 2023 •
edited
Loading

This pr adds a production addon values file with best practices for using ingress-nginx with spire-oidc-discovery-provider and tests all existing ingresses to ensure they work properly.

@kfox1111 kfox1111 marked this pull request as draft March 17, 2023 23:48
@kfox1111 kfox1111 marked this pull request as ready for review March 18, 2023 15:31
@faisal-memon faisal-memon self-assigned this Mar 21, 2023
@kfox1111 kfox1111 force-pushed the production-ingress-nginx branch from 0dc5a4d to b0737d8 Compare March 22, 2023 13:43
@kfox1111 kfox1111 force-pushed the production-ingress-nginx branch from aec2d98 to 65ef6f0 Compare April 3, 2023 13:55
@kfox1111
Copy link
Contributor Author

kfox1111 commented Apr 3, 2023

Rebased

@kfox1111 kfox1111 force-pushed the production-ingress-nginx branch from 65ef6f0 to 8eb37f6 Compare April 3, 2023 13:58
@kfox1111 kfox1111 force-pushed the production-ingress-nginx branch from 4942b82 to b7d4053 Compare April 3, 2023 18:37
marcofranssen
marcofranssen suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nitpicks on indents, to use same indent style as the rest of the chart.

Don't like the testing logic being exposed in public API (values.yaml).

charts/spire/charts/spiffe-oidc-discovery-provider/templates/tests/test-connection.yaml Outdated Show resolved Hide resolved
charts/spire/charts/spiffe-oidc-discovery-provider/templates/tests/test-connection.yaml Outdated Show resolved Hide resolved
charts/spire/charts/spiffe-oidc-discovery-provider/values.yaml Outdated Show resolved Hide resolved
examples/production/values-export-ingress-nginx.yaml Outdated Show resolved Hide resolved
@marcofranssen marcofranssen added this to the 0.7.x milestone Apr 4, 2023
@kfox1111 kfox1111 force-pushed the production-ingress-nginx branch from f648dc6 to a82ff7e Compare April 6, 2023 17:12
@marcofranssen marcofranssen force-pushed the production-ingress-nginx branch from 5d5349d to 89aec0c Compare April 24, 2023 19:09
kfox1111 and others added 2 commits April 24, 2023 21:09
@kfox1111 @marcofranssen
ingress-nginx production example
4971fcb 
This patch adds a production addon values file with best practices
for using ingress-nginx.

Signed-off-by: Kevin Fox <[email protected]>
@kfox1111 @marcofranssen
Apply suggestions from code review
c387d9e 
Signed-off-by: kfox1111 <[email protected]>
Co-authored-by: Marco Franssen <[email protected]>
kfox1111 added 6 commits July 26, 2023 15:39
@kfox1111
Try and swich to the new test layout
0c26e93 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Fix formatting
3b2411a 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Fix missing vars
6e9b534 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Fix typo
202551e 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Fix location
7d2dc25 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Fix more test bits
da8507a 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111 kfox1111 marked this pull request as ready for review July 27, 2023 00:37
edwbuck
edwbuck suggested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@edwbuck edwbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some sections of this are hard to read. If we can't easily read it, odds are we will have issues maintaining it.

Please move some of the logic into _helpers.tpl for the production code. For the tests, you can put it in the header of the test file, or in a test _helpers.tpl (based on what's easier for you).

examples/production/README.md Outdated Show resolved Hide resolved
examples/production/values-export-ingress-nginx.yaml Outdated Show resolved Hide resolved
charts/spire/charts/spire-agent/README.md Outdated Show resolved Hide resolved
charts/spire/charts/spire-server/templates/tests/test-connection.yaml Show resolved Hide resolved
charts/spire/charts/spiffe-oidc-discovery-provider/templates/tests/test-connection.yaml Show resolved Hide resolved
kfox1111 added 4 commits July 27, 2023 10:06
@kfox1111
Incorperate feedback
7e9e37b 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Incorperate feedback
4b9e9a0 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Fix structuring
827d202 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Update docs
7904977 
Signed-off-by: Kevin Fox <[email protected]>
@faisal-memon
Copy link
Contributor

@edwbuck all comments have been addressed. do you have time to take another look?

@faisal-memon faisal-memon modified the milestones: 0.12.0, 0.12.1 Aug 17, 2023
@marcofranssen marcofranssen enabled auto-merge (squash) August 24, 2023 07:49
@marcofranssen
Copy link
Contributor

@edwbuck are you OK on how the feedback was addressed? Can we move this one forward?

@marcofranssen marcofranssen merged commit e81a59a into main Aug 29, 2023
44 checks passed
@marcofranssen marcofranssen deleted the production-ingress-nginx branch August 29, 2023 15:22
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
2a83dbe 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <[email protected]>
@marcofranssen marcofranssen mentioned this pull request Sep 15, 2023
Merged
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
4cd53fa 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <[email protected]>
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
ae84d8b 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <[email protected]>
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
66e8708 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edwbuck edwbuck edwbuck approved these changes

@faisal-memon faisal-memon faisal-memon approved these changes

@marcofranssen marcofranssen marcofranssen left review comments

@developer-guy developer-guy Awaiting requested review from developer-guy

@dennisgove dennisgove Awaiting requested review from dennisgove

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath

Assignees

@marcofranssen marcofranssen

@faisal-memon faisal-memon

@edwbuck edwbuck

Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kfox1111 @edwbuck @faisal-memon @marcofranssen