Re-order Neo block not working on multisite after updating from 3.1.8

[bzin]

Description

After updating Neo from 3.1.8 to 3.2.2, re-ordering and disable blocks stop working, it also made blocks completely disappear on another Site where they would be propagated but translated. I had to revert back to 3.1.8 to have everything working again.

Other information

• Neo version: 3.2.2
• Craft version: Craft Pro 4.2.0.2

[ttempleton]

I can see some issues with block reordering having unintended effects in some cases so will look into that. Regarding disabling blocks not working, steps to reproduce would be helpful.

[maxstrebel]

I also get several reports from one of my clients (is on NEO 3.2.1). They report "that the elements have started to jump, even after moving back to their actual spots and it keeps on happening".

---

For context: we have session problems and also see "[warning] craft\elements\db\ElementQuery::prepare: Element query executed before Craft is fully initialized." A lot in the logs.

And we have a lot of warnings "[warning] craft\web\User::_validateUserAgentAndIp: Request didn’t meet the user agent and IP requirement for maintaining a user session." in the logs.

One of our devs sent me this issue, I don't know if this might be somehow related. craftcms/cms#11033

[bzin]

Hi @ttempleton ,

The disable function I am referring is when I have some multiple Neo blocks and I use the top right dropdown in the block item, see screenshot.

Basically when I disable and save, this will do nothing and the block would still be enabled on all sites.

[jesuismaxime]

Also got an unexpected behaviour with ordering with Neo v3.2.2 (Unable to re-order blocks on save, they keep the same order; try with both autoSaveDraft activate and deactivate).

[jesuismaxime]

Well that was quick 😆. Do you have a release (date/time) in mind for this fix?

[ttempleton]

Thanks for the information @bzin, I was able to reproduce it and it should be fixed now.

@jesuismaxime Just released Neo 3.2.3 (please let me know if there are any other issues with reordering blocks!)

[jesuismaxime]

@ttempleton, tested locally and it works fine now! Thanks a lot!

[jesuismaxime]

@ttempleton the native issue that imply 'disable stops working' is still there. Since my issue was about the re-ordering, I didnt think to look at the disable part; but it seems to be still there on v3.2.4

[ttempleton]

Just retested on 3.2.4 and it's still working for me. If you're still having issues with that, could you please open a new issue with as much info as possible regarding steps to reproduce.

[ttempleton]

I just saw it happening with autosaveDrafts set to false, no need to open a new issue.

[ttempleton]

That should be fixed for non-autosaved elements now, for the next release. In the meantime, you can get the fix by setting your composer.json file's spicyweb/craft-neo requirement to 3.x-dev as 3.2.4 and running composer update.

[ttempleton]

Just released Neo 3.2.5, including the fix for the block enabled/disabled state being lost when editing non-autosaved elements. If there are still any issues with the enabled/disabled state being lost anywhere, please let me know.

[bzin]

Thanks a lot @ttempleton,still was not able to test this in the project mentioned above but I am sure it would be working now 😏