Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extension to the blacklist #742

Merged
merged 1 commit into from
May 3, 2024
Merged

feat: add extension to the blacklist #742

merged 1 commit into from
May 3, 2024

Conversation

rxri
Copy link
Member

@rxri rxri commented May 3, 2024

This extension uses LyricsPlus name and such is confusing to our users because they're greeted with modified Lyrics-Plus with some gradient background that cannot be disabled.
If the author will change the name, we can remove it from the blacklist

@rxri rxri requested a review from theRealPadster May 3, 2024 17:58
@rxri rxri requested a review from a team as a code owner May 3, 2024 17:58
@Delusoire
Copy link
Contributor

Yeah, the naming is definitely misleading.

@rxri rxri merged commit 839212f into main May 3, 2024
6 checks passed
@rxri rxri deleted the feat/blacklist branch May 3, 2024 18:02
@dupitydumb
Copy link

hey! the author here. I intended to make the repo for a Chrome extension but some of the users want me to integrate to spicetify! I did not realize there is a custom app named Lyrics Plus before it's too late! turns out I built mine on top of an existing custom app! I have changed the name to custom lyrics. thank you!

@rxri
Copy link
Member Author

rxri commented May 6, 2024

The extension doesn't add custom lyrics so the name is still misleading. It adds gradient background into the lyrics-plus, so you should choose the name accordingly. Even something like Gradientify is fine lol

@dupitydumb
Copy link

well, im currently working to integrated the setting. but I get your point. i have renamed it to Lyrics Glow in the manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants