Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to show archived repos & archived tag #679

Merged
merged 3 commits into from
Jan 24, 2024
Merged

feat: option to show archived repos & archived tag #679

merged 3 commits into from
Jan 24, 2024

Conversation

SunsetTechuila
Copy link
Contributor

No description provided.

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner January 24, 2024 12:54
@SunsetTechuila SunsetTechuila requested review from CharlieS1103 and theRealPadster and removed request for a team and CharlieS1103 January 24, 2024 12:54
@SunsetTechuila SunsetTechuila changed the title feat: hide archived repos & add archived tag feat: option to hide archived repos & archived tag Jan 24, 2024
@SunsetTechuila SunsetTechuila changed the title feat: option to hide archived repos & archived tag feat: option to show archived repos & archived tag Jan 24, 2024
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just some linting stuff.

src/components/Card/TagsDiv.tsx Show resolved Hide resolved
src/components/Card/TagsDiv.tsx Show resolved Hide resolved
src/logic/FetchRemotes.ts Outdated Show resolved Hide resolved
@SunsetTechuila
Copy link
Contributor Author

some linting stuff

What linter should I use to see the warnings? Eslint doesn't show any. And every formatter removes those spaces

@SunsetTechuila
Copy link
Contributor Author

@theRealPadster
Copy link
Member

theRealPadster commented Jan 24, 2024

Hmm, not sure, is it not just ESLint? I always do spaces around curly brackets.
image

Says ESLint?
image

@SunsetTechuila
Copy link
Contributor Author

Hmm, not sure, is it not just ESLint? I always do spaces around curly brackets.

you are showing a regular js, not jsx

@theRealPadster
Copy link
Member

theRealPadster commented Jan 24, 2024

you are showing a regular js, not jsx

It's in the FetchRemotes.ts file, like in the above comment/suggestion.

@SunsetTechuila
Copy link
Contributor Author

like in the above comment/suggestion.

I have committed suggestion for the FetchRemotes.ts, I'm speaking about TagsDiv.tsx rn

@theRealPadster
Copy link
Member

I have committed suggestion for the FetchRemotes.ts, I'm speaking about TagsDiv.tsx rn

Ah, maybe the ESLint rules don't apply to the tsx then, but I think it makes sense to follow the same conventions across both.

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Jan 24, 2024

I think it makes sense to follow the same conventions across both.

Are you sure? JSX has different conventions. That's why eslint shows nothing
But I'll add the spaces if you insist

@theRealPadster
Copy link
Member

It looks like it's an option. I'm sure there are different style guides, but I'm used to using spaces and regardless which we do, I think we should be consistent between js/jsx files in the same project.

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Jan 24, 2024

I think we should be consistent

image

image

image

@rxri
Copy link
Member

rxri commented Jan 24, 2024

ew in jsx you shouldn't have curly spacing. looks bad af

@theRealPadster
Copy link
Member

ew in jsx you shouldn't have curly spacing. looks bad af

Literally looks the exact same as in JS.

But okay if it's all done without spaces currently then I guess let's leave it. 🤷

@SunsetTechuila SunsetTechuila merged commit 6b3bd28 into spicetify:main Jan 24, 2024
5 checks passed
@SunsetTechuila SunsetTechuila deleted the archive branch January 24, 2024 16:12
@rxri
Copy link
Member

rxri commented Jan 24, 2024

ew in jsx you shouldn't have curly spacing. looks bad af

Literally looks the exact same as in JS.

But okay if it's all done without spaces currently then I guess let's leave it. 🤷

tbh I have never seen JSX code with style like this. JS and JSX are not the same and shouldn't be connected with styles. JS has imports with curly spacing because that's how "it was designed" and JSX was designed to not have them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants