Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snippets): improve the code of few snippets #674

Merged
merged 7 commits into from
Feb 2, 2024
Merged

fix(snippets): improve the code of few snippets #674

merged 7 commits into from
Feb 2, 2024

Conversation

SunsetTechuila
Copy link
Contributor

No description provided.

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner December 21, 2023 11:58
@SunsetTechuila SunsetTechuila requested review from CharlieS1103 and removed request for a team December 21, 2023 11:58
@SunsetTechuila SunsetTechuila changed the title fix(snippets): move from aria-label fix(snippets): improve the code Dec 21, 2023
theRealPadster
theRealPadster approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming they all still work :)

@SunsetTechuila
Copy link
Contributor Author

as far as I tested - they do
but don't merge rn, please, I'll do that later myself

@rxri rxri changed the title fix(snippets): improve the code feat(snippets): improve the code of few snippets Dec 21, 2023
@SunsetTechuila SunsetTechuila changed the title feat(snippets): improve the code of few snippets fix(snippets): improve the code of few snippets Jan 25, 2024
@SunsetTechuila
Copy link
Contributor Author

this pr should be ready to merge

@rxri rxri merged commit d7316c7 into spicetify:main Feb 2, 2024
5 checks passed
@SunsetTechuila SunsetTechuila deleted the fix-snip branch February 2, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieS1103 CharlieS1103 Awaiting requested review from CharlieS1103 CharlieS1103 is a code owner automatically assigned from spicetify/marketplace

@theRealPadster theRealPadster Awaiting requested review from theRealPadster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunsetTechuila @theRealPadster @rxri