Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): add packageManager #638

Merged
merged 7 commits into from
Nov 4, 2023
Merged

chore(package.json): add packageManager #638

merged 7 commits into from
Nov 4, 2023

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Nov 3, 2023

version: latest

not needed if the version is specified in package.json
link

"node": ">=18"

there is no reason to have 20 here, check the dependencies. npm and pnpm only show a warning, but yarn throws an error if you have the node ver less than 20

"build:prod": "npm run build:local && npm run copy:docs"

why have pnpm here if we don't force to use it?

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner November 3, 2023 21:28
@SunsetTechuila SunsetTechuila requested review from theRealPadster and removed request for a team November 3, 2023 21:28
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@SunsetTechuila
Copy link
Contributor Author

@theRealPadster did you read the pr description?

@theRealPadster
Copy link
Member

@theRealPadster did you read the pr description?

Yes. It sounded to me like you were going to make the scripts use pnpm, but then I looked and it's changing it back to npm

@rxri rxri changed the title chore(package.json): add packageManager && make scripts pm-independent chore(package.json): add packageManager Nov 4, 2023
.npmrc Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@theRealPadster theRealPadster merged commit 6d45d77 into spicetify:main Nov 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants