Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install/windows): use provided userdata path #613

Merged
merged 1 commit into from
Oct 15, 2023
Merged

feat(install/windows): use provided userdata path #613

merged 1 commit into from
Oct 15, 2023

Conversation

SunsetTechuila
Copy link
Contributor

brings support for scoop/winget/etc spicetify installations, but will still work if spicetify returns error/warning with/without path - no cons

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner October 13, 2023 16:13
@SunsetTechuila SunsetTechuila requested review from CharlieS1103 and removed request for a team October 13, 2023 16:13
@theRealPadster
Copy link
Member

I installed WingetUI on my PC, to make it slightly more like a proper package management system, but when I try and update Spicetify via there, it fails and gives me this error:

Successfully verified installer hash
Extracting archive...
Successfully extracted archive
Starting package install...
Unable to remove Portable package as it has been modified; to override this check use --force

This is supposed to fix that somehow? Is there some way I can test it? I don't use powershell at all and have no idea how this stuff works lol.

@SunsetTechuila
Copy link
Contributor Author

This is supposed to fix that somehow?

No, scoop (definitely) and winget (probably) install spicetify to different locations and spicetify uses different folders to store user data, so when the script installs marketplace to appdata/roaming it fails to apply. So the main point is to fix this by calling spicetify to get the user data path instead of using the hardcoded path

@SunsetTechuila
Copy link
Contributor Author

may be relevant for chocolatey as well

@theRealPadster
Copy link
Member

Ah, this is the marketplace install script, I was thinking it was the main one. I can probably test it later today then. Sounds like a good idea to me

@theRealPadster theRealPadster changed the title feat(windows/install): use spicetify provided userdata path if possible feat(install/windows): use spicetify provided userdata path if possible Oct 15, 2023
@rxri rxri changed the title feat(install/windows): use spicetify provided userdata path if possible feat(install/windows): use provided userdata path Oct 15, 2023
@theRealPadster theRealPadster merged commit 4648055 into spicetify:main Oct 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants