Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid styles): header position and background #610

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fix(grid styles): header position and background #610

merged 3 commits into from
Oct 12, 2023

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Oct 11, 2023

before:

image

image

after:

image

image

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner October 11, 2023 19:23
@SunsetTechuila SunsetTechuila requested review from CharlieS1103 and removed request for a team October 11, 2023 19:23
@SunsetTechuila
Copy link
Contributor Author

I don't think sticky header is a good idea tho

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, I think this is what I was going for originally. Thanks for catching the readme bug too 🙃

@theRealPadster
Copy link
Member

I don't think sticky header is a good idea tho

I personally found it really annoying to have to scroll all the way up to the top to change colour schemes or search. Maybe we can tighten the spacing up a bit so it's not as tall?

@theRealPadster
Copy link
Member

I would also remove this part. It doesn't let me suggest on unmodified lines I guess.

.marketplace-header__left {
  position: absolute;
  left: 0;
}

@theRealPadster
Copy link
Member

Screenshot for reference
image

@SunsetTechuila
Copy link
Contributor Author

I would also remove this part. It doesn't let me suggest on unmodified lines I guess.

done

@theRealPadster theRealPadster merged commit dbcf1a7 into spicetify:main Oct 12, 2023
5 checks passed
@AliahX
Copy link

AliahX commented Jun 19, 2024

This seems to have caused another issue?
The marketplace header is now displayed on top of the page content even when scrolled all the way to the top of the page, obscuring headers and anything else at the top of the page.

Screenshot 2024-06-19 173048
Here is a screenshot showing the issue. you can see in this image, the themes header is obscured by the sticky header.

image
This is another page affected by the (same?) issue

Screenshot 2024-06-19 173210
This is a fix I made by messing around with the css a bit, but it affected non spicetify pages too. You can see that the themes header is now visible.

@rxri
Copy link
Member

rxri commented Jun 19, 2024

This didn't cause any issues. It's an issue with global navbar and I don't feel like fixing it in spicetify itself so it's up to developer to fix it. Marketplace has it already fixed with margin-top assigned to the tabbar.

@AliahX
Copy link

AliahX commented Jun 19, 2024

You're right yeah. idk why I sent this in the marketplace repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants