Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snippets): dancing duck #549

Merged
merged 3 commits into from
Jul 13, 2023
Merged

feat(snippets): dancing duck #549

merged 3 commits into from
Jul 13, 2023

Conversation

Marcynas
Copy link
Contributor

No description provided.

@Marcynas Marcynas requested a review from a team as a code owner July 13, 2023 11:44
@Marcynas Marcynas requested review from theRealPadster and removed request for a team July 13, 2023 11:44
@Marcynas Marcynas changed the title dancing duck snippet feat(Snippet): dancing duck snippet Jul 13, 2023
kyrie25
kyrie25 requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for you to add a preview of the snippet usage inside the client (i.e. where the duck is positioned, how it looks like in the Spotify client, etc.), instead of the duck itself?

@rxri rxri changed the title feat(Snippet): dancing duck snippet feat(snippets): dancing duck snippet Jul 13, 2023
@rxri rxri changed the title feat(snippets): dancing duck snippet feat(snippets): dancing duck Jul 13, 2023
@Marcynas Marcynas closed this Jul 13, 2023
@kyrie25
Copy link
Member

kyrie25 commented Jul 13, 2023 •
edited
Loading

May I ask if there are any issues with the Pull Request? All seems good to me and it was ready to be merged.

@Marcynas Marcynas reopened this Jul 13, 2023
@Marcynas
Copy link
Contributor Author

Sorry, got lost and missclicked

@kyrie25 kyrie25 merged commit 2af0a35 into spicetify:main Jul 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrie25 kyrie25 kyrie25 approved these changes

@theRealPadster theRealPadster Awaiting requested review from theRealPadster theRealPadster is a code owner automatically assigned from spicetify/marketplace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcynas @kyrie25