Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): sorting options #545

Merged
merged 17 commits into from
Oct 11, 2023
Merged

feat(grid): sorting options #545

merged 17 commits into from
Oct 11, 2023

Conversation

CharlieS1103
Copy link
Member

No description provided.

@CharlieS1103 CharlieS1103 requested a review from a team as a code owner July 8, 2023 04:59
@CharlieS1103 CharlieS1103 requested review from theRealPadster and a team and removed request for a team July 8, 2023 04:59
src/components/Grid.tsx Outdated Show resolved Hide resolved
src/components/Grid.tsx Outdated Show resolved Hide resolved
src/components/Grid.tsx Outdated Show resolved Hide resolved
src/components/Grid.tsx Show resolved Hide resolved
src/logic/Utils.ts Outdated Show resolved Hide resolved
src/components/Grid.tsx Show resolved Hide resolved
@CharlieS1103
Copy link
Member Author

@theRealPadster Thoughts on merging as is, in terms of the apps and installed tabs to be entirely honest we have so few of them i doubt it'd be fully necessary to implement as of now, plus the systems they use are entirely different to the themes and extensions tabs so it would probably take loads more work to implement

@theRealPadster
Copy link
Member

I've done some more work on it. Added support for sort to the rest of the tabs (though stars/oldest/newest don't do anything for snippets). I considered disabling/removing those for the Snippets tab, but that made the sort reset when you switched tabs, which was kind of annoying, so I removed it. I'd be okay if we just remove the sort dropdown on the Snippets tab full stop, but up to you guys.

I also fixed the header not being sticky when you scroll, and replaced the redundant "spicetify marketplace" text on the left with the sort dropdown and a label.

image

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theRealPadster theRealPadster merged commit 7201e23 into main Oct 11, 2023
5 checks passed
@theRealPadster theRealPadster deleted the sort-options branch November 5, 2023 00:01
@SunsetTechuila SunsetTechuila linked an issue Dec 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add (implement) sorting options
2 participants