feat: settings modal styling #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theRealPadster
added
💫 enhancement
I'm thinking of using this library to add drag to reorder support for the tabs. Do you think that makes sense to put in this PR or a separate one? |
Since we reworking the modal in the first place I think it's better to do it on this one. |
|
I'm just gonna revert the drag and drop thing for now so I can get this PR done. We can try it again later if we want. |
|
Looks like this now. Is that fine? (In two parts because it's tall)
|
rxri
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be for redesigning the settings modal. Adding dividers like Nord Spotify has seems to help clean things up a little bit, but it would be nice to simplify things more as outlined in #465
This is what I have so far.
