Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readme): set img relative to readme #459

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix(readme): set img relative to readme #459

merged 2 commits into from
Mar 17, 2023

Conversation

harbassan
Copy link
Member

Fixes the image urls being wrong for all of the themes from the spictify-themes repo. spicetify/spicetify-themes#901

@harbassan harbassan requested a review from a team as a code owner March 17, 2023 08:48
@harbassan harbassan requested review from kyrie25 and removed request for a team March 17, 2023 08:49
@kyrie25
Copy link
Member

kyrie25 commented Mar 17, 2023 •
edited
Loading

When the link starts with a /, it is relative to the root of the repository (regardless of whether the markdown file is nested in subdirectories)

Should cover for this case as well.

@harbassan
Copy link
Member Author

sure

@kyrie25 kyrie25 changed the title fix: set readme img urls relative to readme fix(readme): set img relative to readme Mar 17, 2023
@kyrie25 kyrie25 merged commit 67db5e4 into spicetify:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrie25 kyrie25 kyrie25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harbassan @kyrie25