Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'Fix playlist and folder position' snippet #433

Merged
merged 8 commits into from
Mar 18, 2023

Conversation

Plueres
Copy link
Contributor

@Plueres Plueres commented Feb 6, 2023

  • Added a workaround to fix a problem where some playlists at the bottom were not visible when the list of playlists were too long.
    Also added the changes to the likes songs playlist and create playlist button.

Added a workaround to fix a problem where some playlists at the bottom were not visible when the list of playlists were too long. 
Also added the changes to the likes songs playlist and create playlist button.
removed !important
@Plueres Plueres requested a review from a team as a code owner February 6, 2023 08:41
@Plueres Plueres requested review from rxri and removed request for a team February 6, 2023 08:41
@Plueres
Copy link
Contributor Author

Plueres commented Mar 9, 2023

I've added the exclusion of the made for you extension

@Plueres Plueres changed the title Updated 'Fix playlist and folder position' snippet Fix: 'Fix playlist and folder position' snippet Mar 13, 2023
@theRealPadster
Copy link
Member

Hey, sorry this is taking so long. Could you post some screenshots or a way to reproduce what this is trying to fix? It doesn't really seem to do anything when I try it, so I've just been leaving the PR.

@theRealPadster theRealPadster changed the title Fix: 'Fix playlist and folder position' snippet fix: 'Fix playlist and folder position' snippet Mar 14, 2023
@Plueres
Copy link
Contributor Author

Plueres commented Mar 15, 2023

Hey, sorry this is taking so long. Could you post some screenshots or a way to reproduce what this is trying to fix? It doesn't really seem to do anything when I try it, so I've just been leaving the PR.

At first, if you have a really long list of playlists it would cut off the last few and just take the padding of the liked playlist and create new playlist. With the fix it makes the spacing of the liked songs playlist and create new playlist al little smaller so it is in line with the general playlist spacing and adds a little bit more height instead.
I am using a theme but the function is the same

Before
image
After
image

For the custom app icons if you have the made for you extension installed

Before
image
After
image

Hope this clears everything up, if not, please let me know.

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, sounds good 👍

@theRealPadster theRealPadster merged commit 4a32f2b into spicetify:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants