Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Spanish translation #375

Merged
merged 5 commits into from
Nov 14, 2022
Merged

Add a Spanish translation #375

merged 5 commits into from
Nov 14, 2022

Conversation

Dan-megabyte
Copy link
Contributor

Adding a Spanish translation will help Spicetify reach a greater audience

@Dan-megabyte Dan-megabyte requested a review from a team as a code owner November 13, 2022 14:37
@Dan-megabyte Dan-megabyte requested review from CharlieS1103 and removed request for a team November 13, 2022 14:37
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a Spanish translation will help Spicetify reach a greater audience

No doubt! I just need to point out a small part here and we should be good to go :)

packages/marketplace/src/resources/locales/es.json Outdated Show resolved Hide resolved
Copy link
Member

@CharlieS1103 CharlieS1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks! My only other note would be the fact that I have this PR open that adds translations for the import/export feature, and it might make sense for you to add those in here as well. Up to you, can always add in another PR.
#369

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has been merged in. Could you add the new strings?

@Dan-megabyte
Copy link
Contributor Author

Backup translations has been added.

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@theRealPadster theRealPadster merged commit 05b1706 into spicetify:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants