Added Hide Playing Gif Snippet #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notPlancha
requested review from
theRealPadster
and removed request for
a team
CharlieS1103
requested changes
Sep 6, 2022
|
Tbh I doubt it too but it was an easy fix that's why I did it |
notPlancha
requested review from
CharlieS1103
and removed request for
theRealPadster
|
Can you add like 20-25% empty space around the edges of the preview? To make it look more consistent with the rest. |
|
I fixed the ratio to be consistent, hopefully that's what you asked for |
Not quite what I meant (other icon-only snippets have some transparent padding around the edges), but it looks like it's big enough to fill the snippet preview square, so is probably fine as is. |
theRealPadster
approved these changes
Sep 6, 2022
CharlieS1103
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the Now playing gif can be heavy on the cpu, so this snippet hides it. redd.it/x6pvw0