Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): card filter on search #288

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix(grid): card filter on search #288

merged 1 commit into from
Jul 25, 2022

Conversation

pnthach95
Copy link
Contributor

When typing in search textbox, items in Grid is changed visually (except star count). But when you press install button, it installs item at position in initial list.

Example:

  • Open Marketplace, Extensions tab
  • Enter copy in search textbox
  • Press Install at Copy to Clipboard, console log says it installed Hide Podcasts extension
bug.mp4

After fix:

fix.mp4

@pnthach95 pnthach95 requested a review from a team as a code owner July 25, 2022 08:26
@pnthach95 pnthach95 requested review from kyrie25 and removed request for a team July 25, 2022 08:26
@kyrie25
Copy link
Member

kyrie25 commented Jul 25, 2022

@theRealPadster lol the key was breaking Cards after all

Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the changes worked on my local environment as well, LGTM. Thanks for the fix!

@kyrie25 kyrie25 changed the title Fix installing item on search result list fix(grid): card filter on search Jul 25, 2022
@kyrie25 kyrie25 merged commit 17b2a16 into spicetify:main Jul 25, 2022
@pnthach95 pnthach95 deleted the fix-search branch July 25, 2022 08:42
@CharlieS1103
Copy link
Member

@kyrie25 Lmfao I remember talking about this with you

@kyrie25
Copy link
Member

kyrie25 commented Jul 25, 2022

@kyrie25 Lmfao I remember talking about this with you

ik lmao I didn't think it was the one breaking but still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants