Add poll_now_notify parameter to poll_loop and on_work_available callback - #12
Merged
Merged
Conversation
phillipleblanc
commented
Jan 26, 2026
phillipleblanc
commented
- Add poll_now_notify: Option<Arc> parameter to poll_loop in execution_loop.rs
- Update idle sleep to use tokio::select! - wakes on 100ms timeout OR notify signal
- Add OnWorkAvailableFn callback type and field to SchedulerConfig
- Invoke callback after JobSubmitted and TaskUpdating events when new work available
- Update standalone executor and executor_process to pass None for poll_now_notify
…back - Add poll_now_notify: Option<Arc<Notify>> parameter to poll_loop in execution_loop.rs - Update idle sleep to use tokio::select! - wakes on 100ms timeout OR notify signal - Add OnWorkAvailableFn callback type and field to SchedulerConfig - Invoke callback after JobSubmitted and TaskUpdating events when new work available - Update standalone executor and executor_process to pass None for poll_now_notify
phillipleblanc
force-pushed
the
phillip/260126-poll-loop-interrupt
branch
from
January 26, 2026 07:03
e0ab27e to
6088cdb
Compare
sgrebnov
approved these changes
Jan 26, 2026
|
Hey @phillipleblanc I've noticed you guys are doing great job extending ballista, would you consider contributing patches back to ballista for things like #12, #13, #14, #15 ? |
|
Also, it would be great if could get involved into steering ballista's direction |
Author
|
@milenkovicm Yes! We can definitely upstream some of the work we've been doing. What would be the best way to start participating in steering ballista's direction? |
|
cool! if ok, i would cherry pick few commits from your repo an back-port them to ballista, will add you do PR review. also, feel free to suggest things needed on master with regards to ballista steering participations, whatever you guys have bandwidth to do, even just opening bugs or keeping an eye on PR would be appreciated |
This was referenced Jun 23, 2026
Merged
phillipleblanc
added a commit
that referenced
this pull request
Jul 27, 2026
…he#1892) * feat: allow an external semaphore for executor task concurrency Adds an optional available_task_slots: Option<Arc<Semaphore>> parameter to the executor poll_loop. When provided, the caller supplies the semaphore that bounds concurrent task execution; this enables sharing it across poll loops connected to different schedulers and observing executor busy state via available_permits(). When None, the loop creates one internally sized to the executor's task slots (unchanged behavior). Ported from #14 for upstreaming. Note: layers on the poll_loop signature; if landed after #12 (poll_now_notify) it needs a trivial rebase to add both parameters. * fix(examples): pass optional semaphore arg in mtls-cluster and reformat standalone * fix(executor): address PR review feedback on shared-semaphore poll_loop - Handle AcquireError from semaphore acquire/acquire_owned by mapping to BallistaError instead of panicking, since the semaphore may now be externally owned and closed by the caller - Assert that the provided semaphore has at least one permit on entry to fail fast rather than deadlock - Rewrite poll_loop doc comment to be public-facing: remove references to internal variable names and implementation types, document shared- semaphore over-commit semantics and sizing tradeoffs in behavioral terms, and add a # Panics section for the zero-permit case * style: cargo fmt execution_loop.rs --------- Co-authored-by: Phillip LeBlanc <879445+phillipleblanc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.