Discrepancy between hard-coded file & in-memory patching #220
Comments
|
If the texture problem is from mdata, try running with -avsverbose to see if it's even opening the correct file (the 0x61 -> 0x6F patch should change mdata.ifs to mdato.ifs?) |
|
This doesn't sound like a mem patch issue, more like you missed a patch that is needed to make Omni work, as pointed out above. If you can narrow it down to a single patch & can prove that it's not being applied (such as via the memory overlay or under a debugger) feel free to respond back. |
sp2xdev
added
not_tools_issue
The patch is the aforementioned As for the in-memory version of that patch, it appears that it is being applied:
After stepping over the
More confirmation of the altered filename in-game, despite the still present visual issues.
With the pre-patched file, it opens However, with the in-memory patch applied it still opens the original file instead: Curiously, further down the log it does open Looking in IDA, ...and as far as I can tell, spice2x is definitely applying the patches correctly; it's just an issue of timing. I can't think of any good ways of addressing this as it's already too late as soon as Oh well. At least it's good to know that static patches in a file don't necessarily translate 1:1 when expressed as memory patches. Unfortunately, altering that one patch doesn't work either, as the offset of the copy exceeds the file size. |
|
Thank you for looking into this deeper. Maybe it's time to split it off as a hook DLL+layeredfs? Spicetools patching, mempatch-hook and layeredfs have been around for many years now and they don't seem to be in a rush to move from the "use bm2dx_omni.dll with mystery patches and pollute your game data folder" model... while other projects seem to have embraced all of the tool upgrades since 2013. Bonus: |
|
Exact same issue happening with people now creating Epolis' omnimix and mdata.ifs. Hard-patching the DLL does work, memory patching doesn't. |
|
Here's a potential workaround that attempts to use LdrRegisterDllNotification to apply changes a bit earlier. It was introduced in Vista, so I left the original code to apply patches after loading the game DLL alone. Tested by building with Docker and comparing behaviour against the latest 24-10-12 binaries while using the same patches and configuration. Confirmed the Omnimix texture issue is no longer present. Also lightly tested with a couple of 32-bit IIDX games to ensure it works there as well, although I'm not aware of any patches that exhibit the same issue. log.txt (24-10-12)log.txt (with patch) |
|
I've merged aixxe's patch above, will do a release soon. One tricky situation that we need to explain is that for patches that were previously no-op can now be working - for example, if someone does not actually have omnimix installed but has Omnimix patch checked, the game would have booted previously, but now it will crash. |
Game and version
beatmania IIDX 30 RESIDENT - LDJ-003-2023090500
Version of spice2x
1.0-V-2024-08-24T00:53:46
Laptop
Replicated on both desktop & laptop
Describe the issue
After isolating the differences between the original
bm2dx.dlland thebm2dx_omni.dllfrom Omnimix v1.30.1 into a spice2x patch, I've noticed some texture issues in music select when playing certain songs (e.g. Scripted Connection⇒ long mix)[ { "type": "memory", "name": "Omnimix", "description": "", "gameCode": "LDJ", "patches": [ { "offset": 5602318, "dllName": "bm2dx.dll", "dataDisabled": "7407", "dataEnabled": "9090" }, { "offset": 9449065, "dllName": "bm2dx.dll", "dataDisabled": "743C", "dataEnabled": "9090" }, { "offset": 9966082, "dllName": "bm2dx.dll", "dataDisabled": "32C0", "dataEnabled": "B001" }, { "offset": 10041005, "dllName": "bm2dx.dll", "dataDisabled": "75", "dataEnabled": "EB" }, { "offset": 11505163, "dllName": "bm2dx.dll", "dataDisabled": "0FB644244085C00F84F800000048837C2448000F84EC000000488B4424480FB6400383F8587539488B4424480FB6400483F858752B488B4424480FB6400583F858751D488B442448C640034A488B442448C6400442", "dataEnabled": "90909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090909090" }, { "offset": 11505256, "dllName": "bm2dx.dll", "dataDisabled": "41", "dataEnabled": "58" }, { "offset": 11523201, "dllName": "bm2dx.dll", "dataDisabled": "0807", "dataEnabled": "FFFF" }, { "offset": 11523205, "dllName": "bm2dx.dll", "dataDisabled": "7F0A", "dataEnabled": "9090" }, { "offset": 11523211, "dllName": "bm2dx.dll", "dataDisabled": "0807", "dataEnabled": "FFFF" }, { "offset": 18601455, "dllName": "bm2dx.dll", "dataDisabled": "61", "dataEnabled": "6F" }, { "offset": 19351851, "dllName": "bm2dx.dll", "dataDisabled": "64617461", "dataEnabled": "6F6D6E69" } ] } ]Attached log.txt file, if available
log_file.txt
log_memory.txt
The text was updated successfully, but these errors were encountered: