Fix #3698: Moving :doc: to std domain broke backwards compatibility #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @tk0miya, this works for me! |
Member
Author
|
Merged. @mgeier thank you for reviewing! |
tk0miya
added a commit
that referenced
this pull request
May 7, 2017
Member
Author
|
I cherry-picked this into 1.6-release branch manually (I'd mistaken about the target branch...) |
cilq
pushed a commit
to cilq/ganeti
that referenced
this pull request
Jun 26, 2020
Building the documentation with manpages fails with sphinx >= 1.6 because of an internal change [1]. By explicitly setting the domain to 'None' when translating the 'manpage' node into a 'doc' node, sphinx's own transformation to handle this change is triggered. [1] sphinx-doc/sphinx#3698 [2] sphinx-doc/sphinx#3699
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #3698.
This migrates
pending_xref(reftype='doc', refdomain=None, ...)to std domain automatically.I'd like to support such nodes during 1.x series.