Skip to content

Conversation

@AA-Turner
Copy link
Member

It's unclear if these attributes are used in third-party projects, and removing them would allow for a great deal of simplification. I'm open to reversing this deprecation if the impact is too large.

A

@AA-Turner AA-Turner merged commit bb5e545 into sphinx-doc:master Jun 10, 2025
25 checks passed
@AA-Turner AA-Turner deleted the cleanup/deprecate-parser-objs branch June 10, 2025 00:50
@bsipocz
Copy link
Contributor

bsipocz commented Jul 2, 2025

This triggered in our CI for MyST-NB, I'm looking into the code now if we in fact use them or just inherited and propagated down the line.

https://github.com/executablebooks/MyST-NB/actions/workflows/tests_devdeps.yml

@bsipocz
Copy link
Contributor

bsipocz commented Jul 3, 2025

Indeed, we are using env in our parser class https://github.com/executablebooks/MyST-NB/blob/master/myst_nb/sphinx_.py#L56 as well as through the Myst-parser lib (https://github.com/executablebooks/MyST-Parser).

It's not trivially clear how difficult it would be to work around these deprecation, and to judge the impact, but I would say there are quite a lot of projects out there that uses MyST-NB for their rendering; a handful of them are listed here: https://executablebooks.org/en/latest/gallery/ but also some libraries such as scipy now relies of MyST-NB for their library documentation build: https://github.com/scipy/scipy/blob/main/pyproject.toml#L99

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants