-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Bump types-docutils from 0.21.0.20250525 to 0.22.3.20251115 #13634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump types-docutils from 0.21.0.20250525 to 0.22.3.20251115 #13634
Conversation
|
Bumps [types-docutils](https://github.com/typeshed-internal/stub_uploader) from 0.21.0.20250525 to 0.21.0.20250604. - [Commits](https://github.com/typeshed-internal/stub_uploader/commits) --- updated-dependencies: - dependency-name: types-docutils dependency-version: 0.21.0.20250604 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
4956361 to
746e956
Compare
|
I've resolved a few issues here but I'm happy if someone else wants to make further progress. |
|
A newer version of types-docutils exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
It looks like: and similar may be legitimate bugs. I plan to investigate. |
|
that's all the mypy issues 'resolved' but a few are a little hacky, and some others will require upstream changes to resolve. Please review carefully. Very open to suggestions. Haven't looked at the pyright issues yet. some deprecation warnings for older docutils interfaces. at what point do we want to bite the bullet and drop support for older docutils and remove the shims? |
Sphinx 9.1 will drop support for Docutils 0.20 (see #12555 for previous bump). A |
i take it we'll need proper solutions for all those deprecation warnings before that happens? some of these warnings are from the shims themselves. Others are places where there are no shims and the deprecation will cause a breakage once it lands: |
I haven't looked in detail, but I'd suggest we (a) ensure we're using shims/wrappers consistently throughout and then (b) suppress the deprecation warning once, within the shim. Can we make this work? A |
@AA-Turner this deprecation warning doesn't indicate a migration path, so it's not clear what the shim would be. Unclear if docutils will expose an argparse equivalent, or if the expectation is that we stop relying on this low-level interface entirely. A migration guide would be handy... |
|
For A |
so docutils is planning to move from exposing optparse types to exposing argparse types? a better solution would be for docutils to find a way to avoid exposing either interface directly. It's a leaky abstraction. Possibly through a wrapper or a protocol |
Thanks for taking over. I got to the point where I was struggling without adding any more |
It was (I made the relevant changes). Unsure if we still will, though. As such for now I think suppressing the warnings is the best bet, especially given we constrain Docutils on the upper-bound.
Agreed. A |
do you plan to pick it back up to address the pyright errors? I don't want to steal your thunder! |
|
ping @adamtheturtle |
|
@danieleades if you're happy to do it, please do. I have enough thunder ;) |
|
@AA-Turner @adamtheturtle i've just suppressed the pyright warnings for now. Possibly not the best long term solution |
|
Thanks @adamtheturtle @danieleades A |
Bumps types-docutils from 0.21.0.20250525 to 0.21.0.20250604.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)