Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ENV_VERSION for _CurrentDocument #13246

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Bump ENV_VERSION for _CurrentDocument #13246

merged 3 commits into from
Jan 16, 2025

Conversation

shimizukawa
Copy link
Member

Purpose

#13151 changed the Environment class, but the ENV_VERSION has not been updated. This causes errors when building with existing environments.

References

sphinx-doc/sphinx-doc-translations#62

#13151 changed the Environment class, but the `ENV_VERSION` has not been updated. This causes errors when building with existing environments.
@AA-Turner AA-Turner changed the title Update ENV_VERSION for #13151 Bump ENV_VERSION for _CurrentDocument Jan 16, 2025
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't bump the env version as there was no release since the last env version bump, but happy to merge this PR.

The JS test fixtures need to be updated to fix the tests (utils/generate_js_fixtures.py).

@AA-Turner AA-Turner added this to the 8.2.0 milestone Jan 16, 2025
@AA-Turner AA-Turner merged commit 099b91a into master Jan 16, 2025
50 checks passed
@AA-Turner AA-Turner deleted the shimizukawa-patch-1 branch January 16, 2025 17:53
@shimizukawa
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants