Skip to content

[CI/CD] patch sphinx.util.inspect_evaluate_forwardref causing CI failures #12317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 3 commits into from
Apr 23, 2024
Merged

[CI/CD] patch sphinx.util.inspect_evaluate_forwardref causing CI failures #12317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18ade57
fix interaction with PEP 695
picnixz Apr 23, 2024
135a2c4
fix interaction with PEP 695
picnixz Apr 23, 2024
eee7fe1
mypy!
picnixz Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sphinx/util/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,13 @@ def _evaluate_forwardref(
localns: dict[str, Any] | None,
) -> Any:
"""Evaluate a forward reference."""
if sys.version_info >= (3, 12, 4):
# ``type_params`` were added in 3.13 and the signature of _evaluate()
# is not backward-compatible (it was backported to 3.12.4, so anything
# before 3.12.4 still has the old signature).
#
# See: https://github.com/python/cpython/pull/118104.
return ref._evaluate(globalns, localns, {}, recursive_guard=frozenset()) # type: ignore[arg-type, misc]
return ref._evaluate(globalns, localns, frozenset())


Expand Down