-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing with Sphinx 7.2+ (also on Python 3.12) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, compatibility is an issue -switching to draft. |
b345516
to
cb601c4
Compare
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 23, 2023
See: sphinx-contrib/jquery#28 Closes: https://bugs.gentoo.org/911837 Signed-off-by: Matoro Mahri <[email protected]>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 24, 2023
See: sphinx-contrib/jquery#28 Closes: https://bugs.gentoo.org/911837 Signed-off-by: Matoro Mahri <[email protected]>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 24, 2023
See: sphinx-contrib/jquery#28 Closes: https://bugs.gentoo.org/911837 Signed-off-by: Matoro Mahri <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 24, 2023
See: sphinx-contrib/jquery#28 Closes: https://bugs.gentoo.org/911837 Signed-off-by: Matoro Mahri <[email protected]> Signed-off-by: Sam James <[email protected]>
mitya57
reviewed
Dec 12, 2023
Since Sphinx is heading towards the standard Path objects, there's no need to monkeypatch the attributes anymore: the Path.resolve() method does the relevant work for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't use patch from #27 in Fedora, because we already build packages with Python 3.12, and the internals of
pathlib.Path
were rewritten. See traceback below.I tried to understand what is the desired outcome of the tests here and since Sphinx is heading towards the standard Path objects, there's no need to monkeypatch the attributes anymore: the
Path.resolve()
method does the relevant work for us.Also, adding tests with Python 3.12 since it's already out.