Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.5.0 #505

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Release v2.5.0 #505

merged 1 commit into from
Jul 9, 2024

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Jul 8, 2024

Closes #486

After this PR is merged, I'll put v2.5.0 tag to the commit.

@lan496 lan496 requested review from LecrisUT and atztogo July 8, 2024 22:33
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (0f50f42) to head (b6012cd).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #505   +/-   ##
========================================
  Coverage    83.90%   83.90%           
========================================
  Files           25       25           
  Lines         8185     8185           
  Branches      1705     1701    -4     
========================================
  Hits          6868     6868           
  Misses        1317     1317           
Flag Coverage Δ
c_api 74.78% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.36% <ø> (ø)
unit_tests 13.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 merged commit a15ae72 into spglib:develop Jul 9, 2024
51 checks passed
@lan496 lan496 deleted the release-v2.5.0 branch July 9, 2024 04:53
@lan496
Copy link
Member Author

lan496 commented Jul 9, 2024

 1089  gco develop
 1090  git pull upstream develop
 1091  git log
 1092  git tag v2.5.0
 1093  git push upstream v2.5.0

https://github.com/spglib/spglib/actions/runs/9851199010

@lan496
Copy link
Member Author

lan496 commented Jul 9, 2024

https://github.com/spglib/spglib/actions/runs/9851199010/job/27200153110

Failed to upload to PyPI

Uploading spglib-2.5.0-cp310-cp310-linux_aarch64.whl
WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Binary wheel 'spglib-2.5.0-cp310-cp310-linux_aarch64.whl' has an       
         unsupported platform tag 'linux_aarch64'.   

@LecrisUT How to deal with it?

@LecrisUT
Copy link
Collaborator

LecrisUT commented Jul 9, 2024

I just saw that. I believe it's related to https://github.com/pypa/cibuildwheel/releases/tag/v2.19.2

Previous release had manylinux_* tag. Let's get renovate, we need to keep up with updates at least before a tag push. Can you install the app, I'll make a PR to configure it. Can check this and this to see it in action.

@lan496
Copy link
Member Author

lan496 commented Jul 9, 2024

Thanks! I've installed under spglib org.

image

@LecrisUT
Copy link
Collaborator

LecrisUT commented Jul 9, 2024

Thanks, it is working now. But even after the update, the issue still persists, I've submitted an issue upstream, let's see how that turns out. This could even be a PyPI issue because, afaiu manylinux is based on centos 7 which was officially decommissioned at the beginning of the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v2.5.0
3 participants