Fix retrieval of pflag stringArray #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pflag.StringArray` suffers from the same problems as `StringSlice` did described in this issue spf13#112
|
|
|
I have run into this same bug in cobra+viper and just tried out your patch. I'm still getting an empty string in the array, instead of an empty array when the flag was not specified. When I change my declaration of the flag from I think fix this is close, because it is stripping out the extra square brackets, but it may need a bit more to remove the empty entry too. |
carolynvs
pushed a commit
to carolynvs/service-catalog
that referenced
this pull request
Jan 26, 2018
Switching from StringArray to StringSlice to workaround spf13/viper#398.
jpeeler
pushed a commit
to kubernetes-retired/service-catalog
that referenced
this pull request
Feb 6, 2018
* Workaround StringArray bug in Viper Switching from StringArray to StringSlice to workaround spf13/viper#398. * Add failing test for viper bug Split up validation and command execution so that we can test them separately * Test remaining svcat command validation
|
Hello, could we merge this bugfix? |
|
This would be extremely helpful for k3d-io/k3d#506 to be fixed. I'd be happy to help, if needed. |
|
I believe some tests may push it forward |
iwilltry42
added a commit
to iwilltry42/viper
that referenced
this pull request
Mar 30, 2021
iwilltry42
added a commit
to k3d-io/k3d
that referenced
this pull request
Mar 30, 2021
rancherio-gh-m
pushed a commit
to k3d-io/k3d
that referenced
this pull request
Mar 30, 2021
Author: iwilltry42 <[email protected]> Date: Tue Mar 30 15:26:37 2021 +0200 [hotfix] use viper fork with fixed stringArray handling from spf13/viper#398
stoobmmelier
pushed a commit
to stoobmmelier/kubetap
that referenced
this pull request
Jul 20, 2021
New flags added for - customProxyPort - disableReadinessProbe - customProxyReadinessPath - env vars Also updated viper to include bug fix for StringArrayP spf13/viper#398
stoobmmelier
pushed a commit
to stoobmmelier/kubetap
that referenced
this pull request
Jul 20, 2021
New flags added for - customProxyPort - disableReadinessProbe - customProxyReadinessPath - env vars Also updated viper to include bug fix for StringArrayP spf13/viper#398 Signed-off-by: stoobmmelier <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pflag.StringArraysuffers from the same problems asStringSlicedid described in this issue #112