Prevent incorrect flag message on bad subcommand parse #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
changed the title
Collaborator
|
Closed via #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid argument is passed to a subcommand, but the root command is runnable, the flags are reparsed and the wrong error message appears to a user.
For instance
If
openshift start nodehas a--imagesflag, but does not have a--masterflag, the parse will fail (good). But after that failure, if openshift is runnable and doesn't have any flags, then the message displayed to the userunknown flag: --imageswhich is incorrect.I've added a test to demonstrate.