Skip to content

perf: Loop over the bash variable directly instead of starting subprocesses. #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marckhouzam merged 1 commit into from
Dec 6, 2025
+2 −2
Merged

perf: Loop over the bash variable directly instead of starting subprocesses. #2333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bash_completionsV2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ __%[1]s_handle_standard_completion_case() {
local longest=0
local compline
# Look for the longest completion so that we can format things nicely
while IFS='' read -r compline; do
for compline in "${completions[@]}"; do
[[ -z $compline ]] && continue

# Before checking if the completion matches what the user typed,
Expand All @@ -352,7 +352,7 @@ __%[1]s_handle_standard_completion_case() {
if ((${#comp}>longest)); then
longest=${#comp}
fi
done < <(printf "%%s\n" "${completions[@]}")
done

# If there is a single completion left, remove the description text and escape any special characters
if ((${#COMPREPLY[*]} == 1)); then
Expand Down