Fix invalid shell completion when used with ~/.cobra.yaml #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cobra completion` outputs invalid output "Using config file:" at the top of the completion script. when ~/.cobra.yaml exists.
|
|
github-actions
bot
added
the
area/cli [deprecated]
|
@darklore thanks for the PR. |
|
Sorry. Reproduce steps
Problem
|
marckhouzam
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
I can reproduce this.
When there's a cobra configuration file, the Cobra cli always prints "Using config file:..." to stdout, which ends up in the shell completion scripts of the Cobra cli.
Sending that output to stderr as done by this PR seems like a reasonable solution. I don't think backwards-compatibility is a big concern in this case.
Thanks @darklore !
Closed
umarcor
approved these changes
Oct 22, 2021
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 5, 2021
`cobra completion` outputs invalid output "Using config file:" at the top of the completion script. when ~/.cobra.yaml exists.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 15, 2021
`cobra completion` outputs invalid output "Using config file:" at the top of the completion script. when ~/.cobra.yaml exists.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 16, 2021
`cobra completion` outputs invalid output "Using config file:" at the top of the completion script. when ~/.cobra.yaml exists.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 25, 2021
`cobra completion` outputs invalid output "Using config file:" at the top of the completion script. when ~/.cobra.yaml exists.
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Dec 7, 2021
`cobra completion` outputs invalid output "Using config file:" at the top of the completion script. when ~/.cobra.yaml exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cobra completionoutputs invalid output "Using config file:" at the top of the completion script. when ~/.cobra.yaml exists.