Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #241

Merged
merged 1 commit into from
May 4, 2020
Merged

fix typo #241

merged 1 commit into from
May 4, 2020

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Apr 17, 2020

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@0xmichalis
Copy link
Collaborator

Hi @dmitris, please sign the CLA so I can get your PR merged, thanks!

@dmitris
Copy link
Contributor Author

dmitris commented May 4, 2020

@Kargakis I signed what the CLA assistent asked me to sign, please merge the PR.

Strictly speaking that piece of text is a DSO, not CLA - it even starts with the word "Developer Certificate of Origin Version 1.1". Would it be possible to change the prompt s/CLA/DSO ?
Also, please consider adding to https://github.com/spf13/afero#contributing something like "The contributors to this repository need to sign " (or even 'factoring out' the contributors requirement in a separate document like CONTRIBUTING.md).

Reference:
https://opensource.com/article/18/3/cla-vs-dco-whats-difference

@0xmichalis 0xmichalis merged commit 38a8ffc into spf13:master May 4, 2020
@dmitris dmitris deleted the patch-1 branch May 5, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmitris @CLAassistant @0xmichalis