Skip to content

Conversation

@zebra-lucky
Copy link
Contributor

@zebra-lucky zebra-lucky commented Nov 25, 2020

After password is entered history screen is shown.
Back button is not work correctly if focus leaved on passwd input.
This commit seems fix the problem.

@ecdsa
Copy link
Member

ecdsa commented Nov 25, 2020

I cannot reproduce the issue. Can you clarify what you mean?

@zebra-lucky
Copy link
Contributor Author

I cannot reproduce the issue. Can you clarify what you mean?

When starting wallet (linux/kivy or android build), after finished password dialog,
and when history screen is shown try to exit (Esc or back button). It's not work as early.
Need more button press. And ElectrumWindow.on_keyboard binding is not called first time.

@ecdsa
Copy link
Member

ecdsa commented Nov 25, 2020

Need more button press

such as?

@zebra-lucky
Copy link
Contributor Author

Need more button press

such as?

Seems 3 in kivy/linux, 4 (not sure) when back button in android pressed.

Users claims exit is misbehave (on Dash fork), and I've found this problem.

Maybe on different versions of kivy it works differently.

@ecdsa
Copy link
Member

ecdsa commented Nov 25, 2020

so, apparently you are not the user who has this issue?
are you sure this is not the old "user needs to press home" bug?
it would be nice if you could reproduce the issue yourself, before you submit a pull request.

@zebra-lucky
Copy link
Contributor Author

so, apparently you are not the user who has this issue?

I'm repeated the problem. For clarity I'll test on 4.0.5 arm64 build in a hour.

@zebra-lucky
Copy link
Contributor Author

zebra-lucky commented Nov 25, 2020

Firstly on linux/kivy:

pip freeze | grep Kivy
Kivy==1.11.1
Kivy-Garden==0.1.4

other requirements from contrib/deterministic-build/*

after showing history and pressing Esc nothing happens

p.s.: on current master (85bce25)

@zebra-lucky
Copy link
Contributor Author

zebra-lucky commented Nov 25, 2020

Testing 4.0.5 arm64 build:

After showing history and pressing back button nothing happens (on second press also).

@zebra-lucky zebra-lucky force-pushed the kivy_unfocus_passwd_field_input branch from 9b21929 to e9bcb6a Compare May 1, 2021 14:46
@zebra-lucky
Copy link
Contributor Author

zebra-lucky commented May 1, 2021

Fixed introduced bug in prev commit (fail on setting Pincode).
The probmem still exists. Simplest way to reproduse is to change password from settings.
And then change pincode from settings and compare count of esc/back button presses is need to exit from settings.

@ecdsa
Copy link
Member

ecdsa commented Sep 6, 2023

the kivy gui was removed in #8591

@ecdsa ecdsa closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants