This repository has been archived by the owner on Jul 12, 2021. It is now read-only.
Port project to Python 3, drop Python 2 support #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage for hex conversions. bytes is similar to Python 2's str type.
…sction in Python 3.
…t we should consider another library.
…e bytes instead of character strings for most things.
…r string response.
…ion and working with bytes.
|
Sorry to hear that. Still, thank you for your effort. I must say that I am very happy with ElectrumX, because it reduces my workload; I did not have much time to work on the server over the last year. History pruning is missing in ElectrumX, though; I think in the long run someone will have to implement it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[not ready to merge]
Started porting this project to Python 3 several months ago with the goal of taking advantage of new Python features that could greatly improve performance (like asyncio). Finding out about @kyuupichan's ElectrumX project has been a shot to the gut, emotionally. I don't think I have it in me to continue with this effort. If had known about that project when I started, I would have focused on contributing to ElectrumX instead, as it has the same goals as I did for this.
I rebased the changes on recent commits to master and have made this pull request in case someone would like to continue where I left off. This contains no performance improvements as it was intended to achieve a baseline as similar as possible to the Python 2 codebase before moving forward. It may have bugs on the storage side as not all of the operations have been fully tested. @bauerj set up a nice Travis CI if someone would like to add to the test suite.
If no one wants to continue this, feel free to close the pull request un-merged.