fix: dev container fmt nightly build dependencies #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 71.46% 71.46%
=======================================
Files 115 115
Lines 8835 8835
=======================================
Hits 6314 6314
Misses 2412 2412
Partials 109 109 ☔ View full report in Codecov by Sentry. |
hulto
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Looks great! Thanks for the contribution @ankit-pn
Go ahead and merge.
Also please fill this survey about how you felt the contributor process went so we can improve it in the future.
https://forms.gle/MqhLYYTDqFFzQeQo7
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it:
fix nightly dependencies for rustfmt in devcontainer build.
Which issue(s) this PR fixes:
Fixes #409