Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): Move filters to backend query #411

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Dec 19, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Moves filtering to get handled by the backend rather than the frontend
  • Changes styling of the task list
  • Expands the details on output view

Which issue(s) this PR fixes:

Screenshots

Screenshot 2023-12-19 at 5 55 07 PM Screenshot 2023-12-19 at 6 19 21 PM

@cmp5987 cmp5987 requested a review from hulto December 19, 2023 23:19
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (836517f) 71.13% compared to head (0e9bc18) 71.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files         109      109           
  Lines        8071     8071           
=======================================
  Hits         5741     5741           
  Misses       2221     2221           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit f3e5886 into main Dec 19, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp/move-filter-to-backend branch December 19, 2023 23:54
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
feat(filters): Move filters to backend query (#411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants