Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tome newlines #400

Merged
merged 18 commits into from
Dec 26, 2023
Merged

Add tome newlines #400

merged 18 commits into from
Dec 26, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Dec 12, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds newlines to tome output after removing the implicit newline in the printer.

Which issue(s) this PR fixes:

Fixes #397

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f3e5886) 71.13% compared to head (fabd91d) 71.17%.

Files Patch % Lines
implants/imix/src/install.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   71.13%   71.17%   +0.04%     
==========================================
  Files         109      109              
  Lines        8071     8084      +13     
==========================================
+ Hits         5741     5754      +13     
  Misses       2221     2221              
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

elif sys.is_windows():
assets.copy("exec_script/hello_world.bat","C:\Windows\Temp\golem_cli_test-copy_script_and_execute")
shell_res = sys.shell("C:\Windows\Temp\golem_cli_test-copy_script_and_execute")
print(shell_res)

print("\n")

copy_script_and_execute()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

cat(input_params['path'])
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

return

download_and_execute(input_params['url'])
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

file_list(input_params['path'])
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

@@ -1 +1,4 @@
print(sys.hostname())
print("\n")
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

ifconfig()
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

netstat()
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

)
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

process_list(input_params['cmd_substring'])
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

shell_cmd(input_params['cmd'])
print("\n")
print("\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline EOF

@hulto hulto requested a review from jabbate19 December 17, 2023 22:33
Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hulto hulto merged commit f130de1 into main Dec 26, 2023
8 checks passed
@hulto hulto deleted the add-tome-newlines branch December 26, 2023 04:07
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add tome newlines (#400)

* Added print new lines.

* Add EOF newline.

* rename eld to eldritch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tome formatting
2 participants